scriptworker_client: properly handle signals in run_command#1030
scriptworker_client: properly handle signals in run_command#1030jcristau wants to merge 1 commit intomozilla-releng:masterfrom
Conversation
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
If I understand correctly, this PR suggests that the combination of #324 + mozilla-releng/scriptworker#480 didn't ever work correctly in the first place?
| ( | ||
| ["bash", "-c", ">&2 echo bar && echo foo && exit -11"], | ||
| 245, | ||
| ["bash", "-c", ">&2 echo bar && echo foo && kill -11 $$"], |
There was a problem hiding this comment.
Clearly this test was wrong originally. #324 also cites some real world testing, which might be good to do if you haven't already.
I think so, yes. I just resurrected this commit that I had sitting around locally since November, around the time of mozilla-releng/scriptworker#626 / https://bugzilla.mozilla.org/show_bug.cgi?id=1864413 which is also relevant for this. |
2 participants
No description provided.